Re: [PATCH] mmc: winbond: don't build on M68K

From: Randy Dunlap
Date: Sun Oct 17 2021 - 15:31:43 EST


On 10/17/21 12:20 PM, Arnd Bergmann wrote:
On Sun, Oct 17, 2021 at 7:59 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

The Winbond MMC driver fails to build on ARCH=m68k so prevent
that build config. Silences these build errors:

../drivers/mmc/host/wbsd.c: In function 'wbsd_request_end':
../drivers/mmc/host/wbsd.c:212:28: error: implicit declaration of function 'claim_dma_lock' [-Werror=implicit-function-declaration]
212 | dmaflags = claim_dma_lock();
../drivers/mmc/host/wbsd.c:215:17: error: implicit declaration of function 'release_dma_lock'; did you mean 'release_task'? [-Werror=implicit-function-declaration]
215 | release_dma_lock(dmaflags);


It looks like m68k and sparc declare this function in asm/floppy.h,
while everyone
else has it in asm/dma.h.

Not sure if it's worth fixing in a better way, but I suspect sparc
would have the
same issue here.

Ah, I should have seen that.
I'll look into a different patch.

thanks.
--
~Randy