Re: [RFC PATCH] sound: ISA: not for M68K

From: Takashi Iwai
Date: Sun Oct 17 2021 - 03:04:04 EST


On Sat, 16 Oct 2021 08:26:02 +0200,
Randy Dunlap wrote:
>
> On m68k, compiling drivers under SND_ISA causes build errors:
>
> ../sound/core/isadma.c: In function 'snd_dma_program':
> ../sound/core/isadma.c:33:17: error: implicit declaration of function 'claim_dma_lock' [-Werror=implicit-function-declaration]
> 33 | flags = claim_dma_lock();
> | ^~~~~~~~~~~~~~
> ../sound/core/isadma.c:41:9: error: implicit declaration of function 'release_dma_lock' [-Werror=implicit-function-declaration]
> 41 | release_dma_lock(flags);
> | ^~~~~~~~~~~~~~~~
>
> ../sound/isa/sb/sb16_main.c: In function 'snd_sb16_playback_prepare':
> ../sound/isa/sb/sb16_main.c:253:72: error: 'DMA_AUTOINIT' undeclared (first use in this function)
> 253 | snd_dma_program(dma, runtime->dma_addr, size, DMA_MODE_WRITE | DMA_AUTOINIT);
> | ^~~~~~~~~~~~
> ../sound/isa/sb/sb16_main.c:253:72: note: each undeclared identifier is reported only once for each function it appears in
> ../sound/isa/sb/sb16_main.c: In function 'snd_sb16_capture_prepare':
> ../sound/isa/sb/sb16_main.c:322:71: error: 'DMA_AUTOINIT' undeclared (first use in this function)
> 322 | snd_dma_program(dma, runtime->dma_addr, size, DMA_MODE_READ | DMA_AUTOINIT);
> | ^~~~~~~~~~~~
>
> and more...
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Jaroslav Kysela <perex@xxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxxx>
> Cc: alsa-devel@xxxxxxxxxxxxxxxx
> Cc: linux-m68k@xxxxxxxxxxxxxxxxxxxx
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Thanks, applied.


Takashi