Re: [PATCH v12 4/5] PCI: qcom: Add a flag in match data along with ops

From: Prasad Malisetty
Date: Thu Oct 07 2021 - 21:59:17 EST


On 2021-10-07 23:33, Stephen Boyd wrote:
Quoting Prasad Malisetty (2021-10-07 10:48:42)
Add pipe_clk_need_muxing flag in match data and configure

This commit text isn't accurate. The flag isn't added in this patch
anymore. Same goes for the commit title/subject. Can you please update
it to say something like "Point match data to config struct"?

Hi Bjorn,

Could you please update below commit text while taking this patch.

"PCI: qcom: Replace ops with struct pcie_cfg in pcie match data.

Add struct qcom_pcie_cfg as match data for all platforms.
Assign appropriate platform ops into qcom_pcie_cfg and read
Using of_device_is_compatible in pcie probe. "

Thanks
-Prasad

If the platform needs to switch pipe_clk_src.

Signed-off-by: Prasad Malisetty <pmaliset@xxxxxxxxxxxxxx>
---

Otherwise code looks fine:

Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>