Re: [PATCH v2] tty: serial: samsung: Improve naming for common macro

From: Krzysztof Kozlowski
Date: Thu Oct 07 2021 - 09:33:16 EST


On 05/10/2021 11:58, Sam Protsenko wrote:
> Having "_USI" suffix in EXYNOS_COMMON_SERIAL_DRV_DATA_USI() macro is
> confusing. Rename it to just EXYNOS_COMMON_SERIAL_DRV_DATA() and provide
> USI registers availability for all Exynos variants instead. While at it,
> also convert .has_usi field type to bool, so its usage is more obvious.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
> ---
> Changes in v2:
> - Converted .has_usi field to boolean
> - Used true/false instead of 1/0 values in
> EXYNOS_COMMON_SERIAL_DRV_DATA() macro
>
> drivers/tty/serial/samsung_tty.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>


Best regards,
Krzysztof