Re: [PATCH v2 2/2] vsock: Enable y2038 safe timeval for timeout

[Arnd Bergmann]

On Thu, Oct 7, 2021 at 2:34 PM Richard Palethorpe <rpalethorpe@xxxxxxxx> wrote:
>
> Reuse the timeval compat code from core/sock to handle 32-bit and
> 64-bit timeval structures. Also introduce a new socket option define
> to allow using y2038 safe timeval under 32-bit.
>
> The existing behavior of sock_set_timeout and vsock's timeout setter
> differ when the time value is out of bounds. vsocks current behavior
> is retained at the expense of not being able to share the full
> implementation.
>
> This allows the LTP test vsock01 to pass under 32-bit compat mode.
>
> Fixes: fe0c72f3db11 ("socket: move compat timeout handling into sock.c")
> Signed-off-by: Richard Palethorpe <rpalethorpe@xxxxxxxx>
> Cc: Richard Palethorpe <rpalethorpe@xxxxxxxxxxxx>

I had a look to make sure you've covered all the tricky corner cases,

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>