Re: [PATCH v1 3/3] kernel.h: Split out container_of() and typeof_memeber() macros

From: Andy Shevchenko
Date: Thu Oct 07 2021 - 05:21:32 EST


On Tue, Jul 13, 2021 at 08:39:22PM +0200, Miguel Ojeda wrote:
> On Tue, Jul 13, 2021 at 1:23 PM Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > Life is messy and can not easily be partitioned into tiny pieces. That
> > way usually ends up being even messier in the end...
>
> I agree measurements would be ideal.
>
> Having said that, even if it makes no performance difference, I think
> it is reasonable to split things (within reason) and makes a bunch of
> other things easier, plus sometimes one can enforce particular
> conventions in the separate header (like I did when introducing
> `compiler_attributes.h`).

It does almost 2% (steady) speedup. I will send a v2 with methodology
and numbers of testing.

--
With Best Regards,
Andy Shevchenko