Re: [PATCH v3 1/8] media: ipu3-cio2 Check num_planes and sizes in queue_setup

From: Ricardo Ribalda
Date: Wed Oct 06 2021 - 18:28:08 EST


Hi Sakari

Thanks for your review :)

On Wed, 6 Oct 2021 at 23:56, Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
>
> Hi Ricardo,
>
> On Fri, Oct 01, 2021 at 11:25:15AM +0000, Ricardo Ribalda wrote:
> > If num_planes is different than zero num_planes and sizes must be
> > checked to support the format.
> >
> > Fix the following v4l2-compliance error:
> >
> > Buffer ioctls (Input 0):
> > fail: v4l2-test-buffers.cpp(717): q.create_bufs(node, 1, &fmt) != EINVAL
> > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL
> >
> > Reviewed-by: Bingbu Cao <bingbu.cao@xxxxxxxxx>
> > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
>
> I attempted to apply the set to my tree but it doesn't seem to.
>
> Do you happen to have extra patches in your tree?


I think that I was on top of Linus.
I just rebased it on top of yours and resend it as v4

Thanks!


>
> I just pushed mine to the master branch here:
>
> https://git.linuxtv.org/sailus/media_tree.git/
>
> --
> Sakari Ailus



--
Ricardo Ribalda