Re: [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file

From: Andy Shevchenko
Date: Wed Oct 06 2021 - 12:14:37 EST


On Fri, Jul 30, 2021 at 10:20:08AM +0800, Lu Baolu wrote:
> Hi Andy,
>
> On 7/30/21 12:35 AM, Andy Shevchenko wrote:
> > Compiler is not happy about hidden declaration of intel_iommu_ops.
> >
> > .../drivers/iommu/intel/iommu.c:414:24: warning: symbol 'intel_iommu_ops' was not declared. Should it be static?
> >
> > Move declaration to header file to make compiler happy.
>
> Thanks for the cleanup. Sharing data structures between different files
> doesn't seem to be a good design. How about adding a helper so that the
> intel_iommu_ops could be a static one?

I don't see any change in the upstream. What's the plan?
Can we take my patch as a quick fix?

--
With Best Regards,
Andy Shevchenko