Re: [PATCH v4 3/7] dt-bindings: memory: lpddr2: Add revision-id properties

[Dmitry Osipenko]

06.10.2021 13:59, Krzysztof Kozlowski пишет:
> On 06/10/2021 01:00, Dmitry Osipenko wrote:
>> Add optional revision-id standard LPDDR2 properties which will help to
>> identify memory chip.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
>> ---
>>  .../memory-controllers/ddr/jedec,lpddr2.yaml         | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
>> index d99ccad54938..01efb43c3425 100644
>> --- a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
>> +++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
>> @@ -24,6 +24,16 @@ properties:
>>            - enum:
>>                - jedec,lpddr2-nvm
>>  
>> +  revision-id1:
>> +    maximum: 255
>> +    description: |
>> +      Revision 1 value of SDRAM chip. Obtained from device datasheet.
>> +
> 
> Also type/ref for uint32 needed.

Also unnecessary :) It's uint32 by default, inferred from the 'maximum'.