Re: [PATCH next] dt-bindings: mmc: arasan,sdci: bring back requirement of clock-output-names

From: Ulf Hansson
Date: Wed Oct 06 2021 - 11:44:54 EST


On Mon, 4 Oct 2021 at 17:17, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxxxxx> wrote:
>
> The schema defines dependency only of clock-output-names on #clock-cells.
> The dependency in opposite direction - requirement of clock-output-names
> if #clock-cells is defined - should be explicitly included in the
> bindings.
>
> Reported-by: Rob Herring <robh@xxxxxxxxxx>
> Fixes: 22ea8ab0dcc4 ("dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>

Applied for next, thanks!

I took the liberty to squash this into the previous commit, and move
the reported-by tag into a reviewed-by tag from Rob.

Feel free to yell at me if there is something you don't like with the
squashed commit.

Kind regards
Uffe


> ---
>
> Fixes tag from the linux-next
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> index dd70431df0b7..de6f076e0ece 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> @@ -158,6 +158,9 @@ properties:
> description:
> The MIO bank number in which the command and data lines are configured.
>
> +dependencies:
> + '#clock-cells': [ clock-output-names ]
> +
> required:
> - compatible
> - reg
> --
> 2.30.2
>