Re: [PATCH 1/7] dt-bindings: arm: apple: Add apple,pmgr binding

[Hector Martin]

On 06/10/2021 15.56, Krzysztof Kozlowski wrote:
> > diff --git a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> > new file mode 100644
> > index 000000000000..0304164e4140
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> > @@ -0,0 +1,74 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/apple/apple,pmgr.yaml#
>
> Please don't store all Apple-related bindings in bindings/arm/apple, but
> instead group per device type like in most of other bindings. In this
> case - this looks like something close to power domain controller, so it
> should be in bindings/power/

This is a controller that, right now, is only used to instantiate device 
power management controls, but the controller itself is just a generic 
syscon device. Depending on the register range, it could conceivably 
encompass other register types (e.g. clock selects) within it, though 
I'm not sure I want to do that right now. Apple calls several of these 
different register sets as a whole a "PMGR". So I'm not sure if it 
really qualifies as "just" a power domain controller. If we want to 
restrict this to the power state portion of PMGR, then it might make 
sense to call it something more specific...

See arm/rockchip/pmu.yaml for the setup this is modeled after.

> No power-domain-cells? Why? What exactly this device is going to do?
> Maybe I'll check the driver first.... :)

It's a syscon, it does nothing on its own. All the work is done by the 
child nodes and the driver that binds to those.

> > +additionalProperties: true
>
> additionalProperties: false

Fixed for v2.

--
Hector Martin (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub