Re: [PATCH 06/11] selftests: net/fcnal: Do not capture do_run_cmd in verbose mode

From: David Ahern
Date: Wed Oct 06 2021 - 10:48:23 EST


On 10/6/21 5:47 AM, Leonard Crestez wrote:
> This way running with -v will show interspersed output from both nettest
> client and server. This helps to identify the order of events.
>
> It is also required in order to make nettest fork in the background by
> itself because shell capturing does not stop if the target forks.
>
> This also fixes SC2166 warning:
> Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
>
> Signed-off-by: Leonard Crestez <cdleonard@xxxxxxxxx>
> ---
> tools/testing/selftests/net/fcnal-test.sh | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>

Reviewed-by: David Ahern <dsahern@xxxxxxxxxx>