Re: [PATCH 1/2] ASoC: dt-bindings: rt9120: Add initial bindings

From: ChiYuan Huang
Date: Wed Oct 06 2021 - 04:47:36 EST


Hi, Mark:
ChiYuan Huang <u0084500@xxxxxxxxx> 於 2021年10月5日 週二 下午8:39寫道:
>
> Mark Brown <broonie@xxxxxxxxxx> 於 2021年10月5日 週二 下午8:29寫道:
> >
> > On Tue, Oct 05, 2021 at 08:25:43PM +0800, ChiYuan Huang wrote:
> > > Mark Brown <broonie@xxxxxxxxxx> 於 2021年10月5日 週二 下午7:49寫道:
> > > > On Tue, Oct 05, 2021 at 09:16:54AM +0800, cy_huang wrote:
> >
> > > > > + richtek,use-dvdd-1p8v:
> > > > > + description: Indicate DVDD 1P8V is used, default for 3P3V or 5V design
> > > > > + type: boolean
> >
> > > > I would expect this to be done through the regulator bindings, they
> > > > would allow the driver to query the supply voltage.
> >
> > > It's more like as the I/O pad voltage.
> > > Must be the same as I2C and I2S signal high level.
> > > It depends on the application SOC design.
> > > From my understanding, not all application SOC I/O voltage uses
> > > regulator interface.
> >
> > It doesn't really matter what the SoC is doing here, you can always add
> > regulator support to your device - you'd be requesting the supplies to
> > your device, if the SoC doesn't request the supplies that go to it that
> > doesn't really make a difference to what your driver does.
> >
> > Please don't take things off-list unless there is a really strong reason
> > to do so. Sending things to the list ensures that everyone gets a
> > chance to read and comment on things.
>
After contacting our HW RD, to support DVDD 1.8V not just SW config,
also HW connections.
To get only DVDD supply voltage is not enough to meet the HW design.
The property seems indeed and need to be used by user's HW connection.

Can this property to be kept?
> Sorry, my fault.
> I just noticed the mail not reply all. Loop all again.