Re: [v3 PATCH 1/5] mm: hwpoison: remove the unnecessary THP check

From: Naoya Horiguchi
Date: Wed Oct 06 2021 - 00:00:38 EST


> Any comment on this patch and patch #3? I'd prefer to fix more
> comments for a new version.

No. Both 1/5 and 3/5 look fine to me. So ...

> On Thu, Sep 30, 2021 at 2:53 PM Yang Shi <shy828301@xxxxxxxxx> wrote:
> >
> > When handling THP hwpoison checked if the THP is in allocation or free
> > stage since hwpoison may mistreat it as hugetlb page. After
> > commit 415c64c1453a ("mm/memory-failure: split thp earlier in memory error
> > handling") the problem has been fixed, so this check is no longer
> > needed. Remove it. The side effect of the removal is hwpoison may
> > report unsplit THP instead of unknown error for shmem THP. It seems not
> > like a big deal.
> >
> > The following patch depends on this, which fixes shmem THP with
> > hwpoisoned subpage(s) are mapped PMD wrongly. So this patch needs to be
> > backported to -stable as well.
> >
> > Cc: <stable@xxxxxxxxxxxxxxx>
> > Suggested-by: Naoya Horiguchi <naoya.horiguchi@xxxxxxx>
> > Signed-off-by: Yang Shi <shy828301@xxxxxxxxx>

Acked-by: Naoya Horiguchi <naoya.horiguchi@xxxxxxx>

Patch 3/5 already has my Signed-off-by, so I think it can be considered
as acked by me.

Thanks,
Naoya Horiguchi