Re: [PATCH v1 2/2] clk: qcom: Add lpass clock controller driver for SC7280

[Taniya Das]

Hello Stephen,

Thanks for your review.

On 9/1/2021 11:08 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2021-08-31 03:36:42)
> > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> > index 0a55967..cd7a5a1 100644
> > --- a/drivers/clk/qcom/Kconfig
> > +++ b/drivers/clk/qcom/Kconfig
> > @@ -394,6 +394,14 @@ config SC_LPASS_CORECC_7180
> >            Say Y if you want to use LPASS clocks and power domains of the LPASS
> >            core clock controller.
> >   
> > +config SC_LPASSCC_7280
> > +       tristate "SC7280 Low Power Audio Subsystem (LPAAS) Clock Controller"
> > +       select SC_GCC_7280
> > +       help
> > +         Support for the LPASS clock controller on SC7280 devices.
> > +         Say Y if you want to use the LPASS branch clocks of the LPASS clock
> > +         controller to reset the LPASS subsystem.
> > +
>
> Can you send another patch to move SC_LPASS_CORECC_7180 under
> SC_GPUCC_7180? This file should be sorted on Kconfig symbol
> alphabetically.

Yes, will send a patch to fix.

> >   config SC_GPUCC_7180
> >          tristate "SC7180 Graphics Clock Controller"
> >          select SC_GCC_7180
> > diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile
> > index 9825ef8..1b33f49 100644
> > --- a/drivers/clk/qcom/Makefile
> > +++ b/drivers/clk/qcom/Makefile
> > @@ -66,6 +66,7 @@ obj-$(CONFIG_SC_GCC_8180X) += gcc-sc8180x.o
> >   obj-$(CONFIG_SC_GPUCC_7180) += gpucc-sc7180.o
> >   obj-$(CONFIG_SC_GPUCC_7280) += gpucc-sc7280.o
> >   obj-$(CONFIG_SC_LPASS_CORECC_7180) += lpasscorecc-sc7180.o
> > +obj-$(CONFIG_SC_LPASSCC_7280) += lpasscc-sc7280.o
>
> This one got it right, almost. LPASSCC comes before LPASS_CORECC though.
Next patch will fix.

> >   obj-$(CONFIG_SC_MSS_7180) += mss-sc7180.o
> >   obj-$(CONFIG_SC_VIDEOCC_7180) += videocc-sc7180.o
> >   obj-$(CONFIG_SC_VIDEOCC_7280) += videocc-sc7280.o

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--