Re: [PATCH v2] mm/memcg: Remove obsolete memcg_free_kmem()

From: Roman Gushchin
Date: Tue Oct 05 2021 - 21:16:15 EST


On Tue, Oct 05, 2021 at 04:24:50PM -0400, Waiman Long wrote:
> Since commit d648bcc7fe65 ("mm: kmem: make memcg_kmem_enabled()
> irreversible"), the only thing memcg_free_kmem() does is to call
> memcg_offline_kmem() when the memcg is still online which can happen when
> online_css() fails due to -ENOMEM. However, the name memcg_free_kmem()
> is confusing and it is more clear and straight forward to call
> memcg_offline_kmem() directly from mem_cgroup_css_free().
>
> Suggested-by: Roman Gushchin <guro@xxxxxx>
> Signed-off-by: Waiman Long <longman@xxxxxxxxxx>

Reviewed-by: Roman Gushchin <guro@xxxxxx>

Thanks, Waiman!