Re: [PATCH 3/7] soc: apple: Add driver for Apple PMGR power state controls

[Hector Martin]

Hi Linus,

On 06/10/2021 01.08, Linus Walleij wrote:
> Hi Hector,
>
> On Tue, Oct 5, 2021 at 6:00 PM Hector Martin <marcan@xxxxxxxxx> wrote:
>
> >   drivers/soc/apple/Kconfig               |  21 ++
> >   drivers/soc/apple/Makefile              |   2 +
> >   drivers/soc/apple/apple-pmgr-pwrstate.c | 281 ++++++++++++++++++++++++
>
> This is traditionally where we put the ARM SoC drivers, but
> Mac has traditionally used drivers/macintosh for their custom
> board etc stuff. Or is that just for any off-chip stuff?
>
> I suppose it doesn't matter much (unless there is code under
> drivers/macintosh we want to reuse for M1), but it could be a bit
> confusing?

Hmm, it seems that tree is mostly about the PowerPC era Macs; the only 
thing enabled for x86 there is MAC_EMUMOUSEBTN. There is also 
platform/x86/apple-gmux.c for an x86 Mac specific thing...

We already broke tradition with the "apple," DT compatible prefix (used 
to be AAPL for the PowerPC Macs), and these chips aren't even just used 
in Macs (e.g. the iPad, which in theory people would be able to run 
Linux on if someone figures out a jailbreak), so perhaps it's time for 
another break here?

--
Hector Martin (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub