Re: [PATCH v8 02/11] x86/tdx: Introduce INTEL_TDX_GUEST config option

[Kuppuswamy, Sathyanarayanan]

On 10/5/21 7:13 AM, Borislav Petkov wrote:
> On Tue, Oct 05, 2021 at 06:29:43AM -0700, Sathyanarayanan Kuppuswamy Natarajan wrote:
> > For the TDX guest, x2apic will be emulated. So it will exist in our
> > case. Even if x2apic or TDX guest is not supported by CPU, it will
> > boot just fine.
>
> Sure but why is it "select" and not "depends"?
>
> Why does X86_X2APIC need to be selected while the others are "depends"?

Since x2APIC will always exist in TDX guest case, we have used select to
enable the support. But since we have dependency on it, I  think "depends"
might be a better choice.

>

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer