Re: [PATCH v2] scsi: advansys: Prefer struct_size over open coded arithmetic

From: Martin K. Petersen
Date: Tue Oct 05 2021 - 00:35:42 EST


On Sat, 25 Sep 2021 13:42:05 +0200, Len Baker wrote:

> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>
> [...]

Applied to 5.16/scsi-queue, thanks!

[1/1] scsi: advansys: Prefer struct_size over open coded arithmetic
https://git.kernel.org/mkp/scsi/c/568778f5572a

--
Martin K. Petersen Oracle Linux Engineering