Re: [PATCH v4] docs: Explain the desired position of function attributes

From: Jonathan Corbet
Date: Mon Oct 04 2021 - 19:09:22 EST


Kees Cook <keescook@xxxxxxxxxxxx> writes:

> While discussing how to format the addition of various function
> attributes, some "unwritten rules" of ordering surfaced[1]. Capture as
> close as possible to Linus's preferences for future reference.
>
> (Though I note the dissent voiced by Joe Perches, Alexey Dobriyan, and
> others that would prefer all attributes live on a separate leading line.)
>
> [1] https://lore.kernel.org/mm-commits/CAHk-=wiOCLRny5aifWNhr621kYrJwhfURsa0vFPeUEm8mF0ufg@xxxxxxxxxxxxxx/
>
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> ---
> v4:
> - fix another stray "void"! This is why code needs a compiler... (thx randy)
> ---
> Documentation/process/coding-style.rst | 30 ++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)

Did I ever mention that I *hate* coding-style patches? :)

In this case I think we're as close as to consensus as things get. In
the absence of a strong reason to the contrary, I'll apply this before
too long.

Thanks,

jon