Re: [PATCH] regulator: dt-bindings: maxim,max8973: convert to dtschema

[Rob Herring]

On Fri, Oct 01, 2021 at 09:46:54AM +0200, Krzysztof Kozlowski wrote:
> Convert the Maxim MAX8973 regulator to DT schema format.  Extend the
> examples with more advanced one for MAX77621 copied from kernel's
> nvidia/tegra210-smaug.dts, licensed under GPL-2.0.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> ---
>  .../bindings/regulator/max8973-regulator.txt  |  52 -------
>  .../bindings/regulator/maxim,max8973.yaml     | 140 ++++++++++++++++++
>  2 files changed, 140 insertions(+), 52 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/regulator/max8973-regulator.txt
>  create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/max8973-regulator.txt b/Documentation/devicetree/bindings/regulator/max8973-regulator.txt
> deleted file mode 100644
> index c2c68fcc1b41..000000000000
> --- a/Documentation/devicetree/bindings/regulator/max8973-regulator.txt
> +++ /dev/null
> @@ -1,52 +0,0 @@
> -* Maxim MAX8973 Voltage Regulator
> -
> -Required properties:
> -
> -- compatible:	must be one of following:
> -			"maxim,max8973"
> -			"maxim,max77621".
> -- reg:		the i2c slave address of the regulator. It should be 0x1b.
> -
> -Any standard regulator properties can be used to configure the single max8973
> -DCDC.
> -
> -Optional properties:
> -
> --maxim,externally-enable: boolean, externally control the regulator output
> -		enable/disable.
> --maxim,enable-gpio: GPIO for enable control. If the valid GPIO is provided
> -		then externally enable control will be considered.
> --maxim,dvs-gpio: GPIO which is connected to DVS pin of device.
> --maxim,dvs-default-state: Default state of GPIO during initialisation.
> -		1 for HIGH and 0 for LOW.
> --maxim,enable-remote-sense: boolean, enable reote sense.
> --maxim,enable-falling-slew-rate: boolean, enable falling slew rate.
> --maxim,enable-active-discharge: boolean: enable active discharge.
> --maxim,enable-frequency-shift: boolean, enable 9% frequency shift.
> --maxim,enable-bias-control: boolean, enable bias control. By enabling this
> -		startup delay can be reduce to 20us from 220us.
> --maxim,enable-etr: boolean, enable Enhanced Transient Response.
> --maxim,enable-high-etr-sensitivity: boolean, Enhanced transient response
> -		circuit is enabled and set for high sensitivity. If this
> -		property is available then etr will be enable default.
> -
> -Enhanced transient response (ETR) will affect the configuration of CKADV.
> -
> --junction-warn-millicelsius: u32, junction warning temperature threshold
> -		in millicelsius. If die temperature crosses this level then
> -		device generates the warning interrupts.
> -
> -Please note that thermal functionality is only supported on MAX77621. The
> -supported threshold warning temperature for MAX77621 are 120 degC and 140 degC.
> -
> -Example:
> -
> -	max8973@1b {
> -		compatible = "maxim,max8973";
> -		reg = <0x1b>;
> -
> -		regulator-min-microvolt = <935000>;
> -		regulator-max-microvolt = <1200000>;
> -		regulator-boot-on;
> -		regulator-always-on;
> -	};
> diff --git a/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml b/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
> new file mode 100644
> index 000000000000..8947d1fa989a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
> @@ -0,0 +1,140 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/maxim,max8973.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX8973/MAX77621 voltage regulator
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> +
> +allOf:
> +  - $ref: regulator.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - maxim,max8973
> +      - maxim,max77621
> +
> +  junction-warn-millicelsius:
> +    #$ref: /schemas/types.yaml#/definitions/uint32

Drop. 

With that,

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

> +    description: |
> +      Junction warning temperature threshold in millicelsius. If die
> +      temperature crosses this level then device generates the warning
> +      interrupts.
> +      Please note that thermal functionality is only supported on MAX77621. The
> +      supported threshold warning temperature for MAX77621 are 120 degC and 140
> +      degC.