Re: [PATCH] spi: cadence: fix static checker warning

From: Dan Carpenter
Date: Mon Oct 04 2021 - 02:49:51 EST


On Sun, Oct 03, 2021 at 09:04:18AM +0200, Parshuram Thombare wrote:
> This patch fixes Smatch static checker warning.
> CDNS_XSPI_CMD_REG_5 is used in ACMD mode and currently
> only STIG mode is enabled which doesn't use CDNS_XSPI_CMD_REG_5
> and hence everything was working in STIG mode.
> Since plan is to use same function cdns_xspi_trigger_command()
> in ACMD mode, increasing size of the array passed to it.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Link: https://lore.kernel.org/linux-spi/20210930134231.GA14363@kili/
> Signed-off-by: Parshuram Thombare <pthombar@xxxxxxxxxxx>

Thanks! There are runtime tools which will detect this read overflow
so let's add a Fixes tag.

Fixes: a16cc8077627 ("spi: cadence: add support for Cadence XSPI controller")

regards,
dan carpenter