Re: [PATCH v3 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe()

From: Jonathan Cameron
Date: Sat Oct 02 2021 - 12:05:23 EST


On Sat, 2 Oct 2021 15:01:56 +0200
Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> wrote:

> On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing <caihuoqing@xxxxxxxxx> wrote:
> >
> > When possible use dev_err_probe help to properly deal with the
> > PROBE_DEFER error, the benefit is that DEFER issue will be logged
> > in the devices_deferred debugfs file.
> > Using dev_err_probe() can reduce code size, and the error value
> > gets printed.
> >
> > Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> as well as:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> # Odroid-C1
Hi Martin,

Confusing tag. Was the second meant to be a Tested-by?

Thanks,

Jonathan
>
> Thanks for your contribution!
>
>
> Best regards,
> Martin