Re: [PATCH v1 1/1] seq_file: Move seq_escape() to a header

From: Andrew Morton
Date: Fri Oct 01 2021 - 19:39:35 EST


On Fri, 1 Oct 2021 15:29:17 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> Move seq_escape() to the header as inliner.

Some reason for doing this would be nice. Does it make the kernel
smaller? Is this performance-sensitive?

> --- a/include/linux/seq_file.h
> +++ b/include/linux/seq_file.h
> @@ -4,6 +4,7 @@
>
> #include <linux/types.h>
> #include <linux/string.h>
> +#include <linux/string_helpers.h>

Why was this added?

> #include <linux/bug.h>
> #include <linux/mutex.h>
> #include <linux/cpumask.h>