Re: [PATCH] mfd: intel-lpss: Add support for MacBookPro16,2 UART

[Andy Shevchenko]

On Fri, Oct 01, 2021 at 07:14:12PM +0100, Lee Jones wrote:
> On Fri, 01 Oct 2021, Andy Shevchenko wrote:
> > On Fri, Oct 01, 2021 at 08:51:46AM +0000, Orlando Chamberlain wrote:

...

> > > +	/* MacBookPro16,2 */
> > 
> > Use
> > 
> > 	/* ICL-N */
> > 
> > here.
> 
> Why is that?

It's a standard way of representing PCH/SoC in the comments in this driver:
- MacBookPro16,2 is not a name of the PCH/SoC
- MacBookPro16,2 is possible not the solely hardware of this chip

Why not to mention this name in the commit message?

-- 
With Best Regards,
Andy Shevchenko