Re: [PATCH 2/2] scsi: ufs: Stop clearing unit attentions

From: Bart Van Assche
Date: Fri Oct 01 2021 - 12:19:46 EST


On 9/30/21 9:58 PM, Adrian Hunter wrote:
On 30/09/2021 22:52, Jaegeuk Kim wrote:
From: Bart Van Assche <bvanassche@xxxxxxxxxx>

Commit aa53f580e67b ("scsi: ufs: Minor adjustments to error handling")
introduced a ufshcd_clear_ua_wluns() call in
ufshcd_err_handling_unprepare(). As explained in detail by Adrian Hunter,
this can trigger a deadlock. Avoid that deadlock by removing the code that
clears the unit attention. This is safe because the only software that
relies on clearing unit attentions is the Android Trusty software and

Did you test this?

This patch series has been tested on an Android phone running the latest Trusty
software but with runtime power management disabled.

Bart.