Re: [PATCH v13 00/35] NVIDIA Tegra power management patches for 5.16

From: Ulf Hansson
Date: Fri Oct 01 2021 - 10:37:27 EST


On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko <digetx@xxxxxxxxx> wrote:
>
> This series adds runtime PM support to Tegra drivers and enables core
> voltage scaling for Tegra20/30 SoCs, resolving overheating troubles.
>
> All patches in this series are interdependent and should go via Tegra tree.
>
> Changelog:
>
> v13: - Fixed compile-test error reported by build bot by reverting the
> mmc/ patch to v11. The sdhci_suspend/resume_host() functions aren't
> available with the disabled CONFIG_PM_SLEEP, some code needs the
> ifdef.
>
> - Added last r-b from Rob Herring for the DT patches.
>
> - Corrected clk/ PM domain-support patch by not using the
> devm_tegra_core_dev_init_opp_table_common() helper, which I
> utilized in v12. The clk driver implements its own power domain
> state syncing and common helper shouldn't be used. This fixes driver
> probing for some clocks on some devices. It was reported by
> Svyatoslav Ryhel for PLLE OPP error on T30 Asus Transformer tablet.

Dmitry, I have looked through the series and besides those comments
that I have posted, I have nothing more to add. Overall it looks good
to me.

Kind regards
Uffe