Re: [PATCH v2 02/16] dt-bindings: i2c: imx: update schema to align with original txt binding

From: Rob Herring
Date: Fri Oct 01 2021 - 09:24:01 EST


On Thu, Sep 30, 2021 at 7:04 PM Li Yang <leoyang.li@xxxxxxx> wrote:
>
> When the binding was converted from txt to yaml, it actually added more
> constrains than the original txt binding which was already used in many
> in-tree DTSes. Some of the newly added constrains are either not valid
> or not neccessary.

IMO, both of these should be fixed in the dts files.

> Not all SoCs use ipg as the clock name for i2c. There is no point in
> having SoC integration information defined in i2c binding. Remove the
> clock name requirement in the schema.

Any name you want is not fine. Your choices are remove clock-names,
add all the names used, or change everyone to use 'ipg'.

> The original txt binding didn't require the order of tx and rx for
> dmas/dma-names. Many in tree DTSes are already using the other order.
> Both orders should just work fine. Update the schema to allow both.

Doesn't sound like a case where defining the order is challenging.

Rob