Re: [PATCH v2] rtl8xxxu: Use lower tx rates for the ack packet

From: Jes Sorensen
Date: Fri Oct 01 2021 - 01:37:43 EST


On 10/1/21 12:00 AM, Chris Chiu wrote:
> According to the Realtek propritary driver and the rtw88 driver, the
> tx rates of the ack (includes block ack) are initialized with lower
> tx rates (no HT rates) which is set by the RRSR register value. In
> real cases, ack rate higher than current tx rate could lead to
> difficulty for the receiving end to receive management/control frames.
> The retransmission rate would be higher then expected when the driver
> is acting as receiver and the RSSI is not good.
>
> Cross out higer rates for ack packet before implementing dynamic rrsr
> configuration like the commit 4830872685f8 ("rtw88: add dynamic rrsr
> configuration").
>
> Signed-off-by: Chris Chiu <chris.chiu@xxxxxxxxxxxxx>
> ---
>
> Changelog:
> v2:
> - Specify the dynamic rrsr commit for reference
> - Remove the unintentional twice reading of REG_RESPONSE_RATE_SET
>
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 6 +++++-
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 2 ++
> 2 files changed, 7 insertions(+), 1 deletion(-)

Acked-by: Jes Sorensen <Jes.Sorensen@xxxxxxxxx>