Re: [PATCH v2] trace/osnoise: Fix missed cpus_read_unlock() in start_per_cpu_kthreads()

From: Zhang, Qiang
Date: Tue Sep 07 2021 - 22:35:18 EST




________________________________________
From: Steven Rostedt <rostedt@xxxxxxxxxxx>
Sent: Wednesday, 8 September 2021 09:17
To: Zhang, Qiang
Cc: bristot@xxxxxxxxxx; bristot@xxxxxxxxxx; mingo@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v2] trace/osnoise: Fix missed cpus_read_unlock() in start_per_cpu_kthreads()

[Please note: This e-mail is from an EXTERNAL e-mail address]

On Tue, 31 Aug 2021 10:29:19 +0800
qiang.zhang@xxxxxxxxxxxxx wrote:

> From: "Qiang.Zhang" <qiang.zhang@xxxxxxxxxxxxx>
>
> When start_kthread() return error, the cpus_read_unlock() need
> to be called.
>
> Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations")
> Cc: <stable@xxxxxxxxxxxxxxx> # v5.14+

>FYI, no need to add the "# v5.14+", as it also breaks my scripts. The
>"Fixes:" tag is now used to know what stable releases it needs to be
>applied to (if any).
>
Thanks Steve
I will resend v3.


>Daniel, that goes for you too, as you suggested it ;-)
>
>-- Steve