Re: [PATCH] drm/amd/display: Fix warning comparing pointer to 0

From: Alex Deucher
Date: Tue Sep 07 2021 - 13:08:00 EST


Applied. Thanks!

Alex

On Mon, Sep 6, 2021 at 5:23 AM Jiapeng Chong
<jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote:
>
> From: chongjiapeng <jiapeng.chong@xxxxxxxxxxxxxxxxx>
>
> Fix the following coccicheck warning:
>
> ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c:643:35-36:
> WARNING comparing pointer to 0.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: chongjiapeng <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c
> index 4a4894e..15491e3 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c
> @@ -640,7 +640,7 @@ void dcn31_clk_mgr_construct(
> sizeof(struct dcn31_watermarks),
> &clk_mgr->smu_wm_set.mc_address.quad_part);
>
> - if (clk_mgr->smu_wm_set.wm_set == 0) {
> + if (!clk_mgr->smu_wm_set.wm_set) {
> clk_mgr->smu_wm_set.wm_set = &dummy_wms;
> clk_mgr->smu_wm_set.mc_address.quad_part = 0;
> }
> --
> 1.8.3.1
>