Re: [PATCH] net: tcp_drop adds `reason` and SNMP parameters for tracing v4

From: Eric Dumazet
Date: Tue Sep 07 2021 - 11:24:47 EST


On Tue, Sep 7, 2021 at 8:12 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> Just curious. Is "Tcp" the normal way to write "TCP" in the kernel? I see
> it in snmp_seq_show_tcp_udp() in net/ipv4/proc.c, but no where else
> (besides doing CamelCase words). Should these be written using "TCP"
> instead of "Tcp". It just looks awkward to me.
>

Yes, we prefer tcp or TCP, although SNMP counters have Tcp in them,
for some reason
( grep Tcp /proc/net/netstat /proc/net/snmp ), that can not be changed.