Re: [PATCH] kernel/irq: Make irq_set_affinity_hint return the real return value

From: Thomas Gleixner
Date: Mon Sep 06 2021 - 05:50:11 EST


On Mon, Sep 06 2021 at 16:20, Hao Peng wrote:
> irq_set_affinity_hint does not return the return value of
> __irq_set_affinity, which makes the state of functions dependent
> on the return value of irq_set_affinity_hint inconsistent.

No, it does not. The affinity hint has been installed even in the case
that __irq_set_affinity() fails.

Setting the affinity in that function is a best effort operation without
any guarantees and in hindsight this should have never been added to
this function.

Thanks,

tglx