Re: [PATCH] clk: rockchip: use module_platform_driver_probe

From: Miles Chen
Date: Sat Sep 04 2021 - 11:00:55 EST


On Fri, 2021-09-03 at 22:59 +0200, Heiko Stübner wrote:
> Am Donnerstag, 2. September 2021, 09:57:13 CEST schrieb Miles Chen:
> > Replace builtin_platform_driver_probe with
> > module_platform_driver_probe
> > because that rk3399 and rk3568 can be built as kernel modules.
> >
> > Cc: Stephen Boyd <sboyd@xxxxxxxxxx>
> > Signed-off-by: Miles Chen <miles.chen@xxxxxxxxxxxx>
>
> on both rk3399 and rk3568:
> Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>
>
> and also
> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
>

thanks for doing the test. I will add your tags in my next patch.
>
> Heiko
>
> > ---
> > drivers/clk/rockchip/clk-rk3399.c | 2 +-
> > drivers/clk/rockchip/clk-rk3568.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/clk/rockchip/clk-rk3399.c
> > b/drivers/clk/rockchip/clk-rk3399.c
> > index 62a4f2543960..a5169156f1d2 100644
> > --- a/drivers/clk/rockchip/clk-rk3399.c
> > +++ b/drivers/clk/rockchip/clk-rk3399.c
> > @@ -1653,7 +1653,7 @@ static struct platform_driver
> > clk_rk3399_driver = {
> > .suppress_bind_attrs = true,
> > },
> > };
> > -builtin_platform_driver_probe(clk_rk3399_driver,
> > clk_rk3399_probe);
> > +module_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
> >
> > MODULE_DESCRIPTION("Rockchip RK3399 Clock Driver");
> > MODULE_LICENSE("GPL");
> > diff --git a/drivers/clk/rockchip/clk-rk3568.c
> > b/drivers/clk/rockchip/clk-rk3568.c
> > index 75ca855e720d..939e7079c334 100644
> > --- a/drivers/clk/rockchip/clk-rk3568.c
> > +++ b/drivers/clk/rockchip/clk-rk3568.c
> > @@ -1719,7 +1719,7 @@ static struct platform_driver
> > clk_rk3568_driver = {
> > .suppress_bind_attrs = true,
> > },
> > };
> > -builtin_platform_driver_probe(clk_rk3568_driver,
> > clk_rk3568_probe);
> > +module_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
> >
> > MODULE_DESCRIPTION("Rockchip RK3568 Clock Driver");
> > MODULE_LICENSE("GPL");
> >
>
>
>
>