Re: [PATCH v3 1/2] ASoC: max98927: Handle reset gpio when probing i2c

From: Alejandro Tafalla
Date: Fri Sep 03 2021 - 11:52:55 EST


On viernes, 3 de septiembre de 2021 10:18:14 (CEST) Andy Shevchenko wrote:
> On Fri, Sep 3, 2021 at 4:51 AM Alejandro <atafalla@xxxxxxxxx> wrote:
> > From: Alejandro Tafalla <atafalla@xxxxxxxxx>
> >
> > Drive the reset gpio if defined in the DTS node.
>
> ...
>
> > + reset_gpio
> > + = devm_gpiod_get_optional(&i2c->dev, "reset",
> > GPIOD_OUT_LOW); + if (IS_ERR(reset_gpio)) {
> > + ret = PTR_ERR(reset_gpio);
> > + return dev_err_probe(&i2c->dev, ret, "failed to request
> > GPIO reset pin");
> Not sure why my comments have been ignored here.
>
> > + }
>
> --
> With Best Regards,
> Andy Shevchenko
Sorry, I misread your suggestion and didn't notice PTR_ERR was also in the
same line.