Re: [PATCH v5 2/2] arm64: dts: mt8192: add eFuse support for MT8192 SoC

From: Matthias Brugger
Date: Fri Sep 03 2021 - 06:06:20 EST




On 14/04/2021 09:17, Yz.Wu@xxxxxxxxxxxx wrote:
> From: Ryan Wu <Yz.Wu@xxxxxxxxxxxx>
>
> Add eFuse node to read Mediatek eFuse
>
> Signed-off-by: Ryan Wu <Yz.Wu@xxxxxxxxxxxx>
> ---
> This patch dependents on "arm64: dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile"[1]
>
> mt8192.dtsi file is needed for this patch.
> Please also accept this patch together with [1].
>
> [1]http://lists.infradead.org/pipermail/linux-mediatek/2020-November/019378.html
> ---
> arch/arm64/boot/dts/mediatek/mt8192.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 9757138..4d4e4de 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -436,6 +436,11 @@
> status = "disable";
> };
>
> + efuse: efuse@11c10000 {
> + compatible = "mediatek,mt8192-efuse",
> + "mediatek,efuse";

Please fix identation.
Binding description mandates a reg property, please help to make the patch
better by adding that property.

Thanks a lot,
Matthias

> + };
> +
> i2c3: i2c3@11cb0000 {
> compatible = "mediatek,mt8192-i2c";
> reg = <0 0x11cb0000 0 0x1000>,
>