Re: [PATCH v2 3/5] signal: Add unsafe_copy_siginfo_to_user()

From: Linus Torvalds
Date: Thu Sep 02 2021 - 12:05:30 EST


On Wed, Sep 1, 2021 at 11:55 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> I'm a little worried about all these unsafe helper in powerpc and the
> ever increasing scope of the unsafe sections. Can you at least at
> powerpc support to objtool to verify them? objtool verifications has
> helped to find quite a few bugs in unsafe sections on x86.

.. yeah, objdump was particularly useful for the really subtle ones
where there are random function calls due to things like KASAN etc.

No human would ever have noticed "oh, we're walking the kernel stack
with user mode accesses enabled because the compiler inserted magical
debug code here". Objdump sees those things - assuming you teach it
about that special user space access enable/disable sequence.

Linus