Re: [PATCH 3/6] mm/page_alloc.c: remove obsolete comment in free_pcppages_bulk()

From: Miaohe Lin
Date: Wed Sep 01 2021 - 03:49:12 EST


On 2021/8/31 21:38, Mel Gorman wrote:
> On Mon, Aug 30, 2021 at 10:10:48PM +0800, Miaohe Lin wrote:
>> It's also confusing now. Remove it.
>>
>
> Why is the whole comment obsolete?
>
> The second two paragraphs about "all pages pinned" and pages_scanned is
> obsolete and can go but the first paragraph is valid.
>

I think the first paragraph is invalid due to the below statement:
"Assumes all pages on list are in same zone, and of same order."
There are NR_PCP_LISTS lists and PAGE_ALLOC_COSTLY_ORDER + 1 + NR_PCP_THP
orders in pcp. So I think it's obsolete.

Should I delete this statement in the first paragraph only?

Many Thanks.