Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for LiteETH

From: Joel Stanley
Date: Mon Aug 23 2021 - 23:52:16 EST


On Mon, 23 Aug 2021 at 18:44, Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Fri, Aug 20, 2021 at 05:17:25PM +0930, Joel Stanley wrote:

> > +
> > + interrupts:
> > + maxItems: 1
> > +
>
> > + rx-fifo-depth: true
> > + tx-fifo-depth: true
>
> Needs a vendor prefix, type, description and constraints.

These are the standard properties from the ethernet-controller.yaml. I
switched the driver to using those once I discovered they existed (v1
defined these in terms of slots, whereas the ethernet-controller
bindings use bytes).

Cheers,

Joel