Re: [PATCH] netfilter: x_tables: handle xt_register_template() returning an error value

From: Florian Westphal
Date: Mon Aug 23 2021 - 18:26:38 EST


Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote:
> Commit fdacd57c79b7 ("netfilter: x_tables: never register tables by
> default") introduces the function xt_register_template(), and in one case,
> a call to that function was missing the error-case handling.
>
> Handle when xt_register_template() returns an error value.
>
> This was identified with the clang-analyzer's Dead-Store analysis.

Fixes: fdacd57c79b7 ("netfilter: x_tables: never register tables by > default")
Reviewed-by: Florian Westphal <fw@xxxxxxxxx>

This needs to go to nf-next.