Re: [PATCH] staging: r8188eu: make rtw_deinit_intf_priv return void

[Pavel Skripkin]

On 8/24/21 12:20 AM, Phillip Potter wrote:
> On Mon, 23 Aug 2021 at 19:41, Pavel Skripkin <paskripkin@xxxxxxxxx> wrote:
> > rtw_deinit_intf_priv() always return success, so there is no need in
> > return value
> >
> > Signed-off-by: Pavel Skripkin <paskripkin@xxxxxxxxx>
> > ---
> >  drivers/staging/r8188eu/os_dep/usb_intf.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> > index e002070f7fba..37694aa96d13 100644
> > --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> > +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> > @@ -129,13 +129,10 @@ static u8 rtw_init_intf_priv(struct dvobj_priv *dvobj)
> >         return rst;
> >  }
> >
> > -static u8 rtw_deinit_intf_priv(struct dvobj_priv *dvobj)
> > +static void rtw_deinit_intf_priv(struct dvobj_priv *dvobj)
> >  {
> > -       u8 rst = _SUCCESS;
> > -
> >         kfree(dvobj->usb_alloc_vendor_req_buf);
> >         _rtw_mutex_free(&dvobj->usb_vendor_req_mutex);
> > -       return rst;
> >  }
> >
> >  static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
> > --
> > 2.32.0
>
> Dear Pavel,
>
> Looks good - going to test your RFC series now btw.

Thank you, Phillip!


Testing this RFC is very important. If it's all ok with it, I am going 
to add proper error handling all across the driver code, based on read() 
errors :)

Btw, we also can add error handling for write() operations, but I think 
it's not _very_ important, since driver won't misbehave in case of write 
failures



With regards,
Pavel Skripkin