Re: [PATCH v5 0/9] Add generic support for kdump DT properties

From: Rob Herring
Date: Mon Aug 23 2021 - 10:52:41 EST


On Mon, Aug 23, 2021 at 5:13 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Rob,
>
> On Sun, Aug 15, 2021 at 5:25 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> > On Wed, Aug 11, 2021 at 10:50:58AM +0200, Geert Uytterhoeven wrote:
> > > This patch series adds generic support for parsing DT properties related
> > > to crash dump kernels ("linux,elfcorehdr" and "linux,elfcorehdr" under
> > > the "/chosen" node), makes use of it on arm32, and performs a few
> > > cleanups. It is an evolution of the combination of [1] and [2].
> >
> > The DT bits look fine to me. How do you expect this to be merged? I'm
> > happy to take it if arch maintainers can ack it.
>
> I had hoped you could take the series...

My current thought is I'll take 2-5, 7 and 8 given that's what I have
acks for and the others can be applied independently.

> > > The series consists of 6 parts:
> > > 1. Patch 1 prepares architecture-specific code (needed for MIPS only)
> > > to avoid duplicating elf core header reservation later.
> > > 2. Patch 2 prepares the visibility of variables used to hold
> > > information retrieved from the DT properties.
> > > 3. Patches 3-5 add support to the FDT core for handling the
> > > properties.
> > > This can co-exist safely with architecture-specific handling, until
> > > the latter has been removed.
> >
> > Looks like patch 5 doesn't have any dependencies with the series?
>
> Indeed. So you can take it independently.
>
> > > 4. Patch 6 removes the non-standard handling of "linux,elfcorehdr" on
> > > riscv.
> >
> > I thought this should be applied for 5.14?
>
> Me too, but unfortunately that hasn't happened yet...

Buried in the middle of this series is not going to encourage it to be
picked up as a fix.

Rob