Re: [PATCH v2] staging: r8188eu: change declaration of Efuse_Read1ByteFromFakeContent

From: Phillip Potter
Date: Sat Aug 21 2021 - 13:02:38 EST


On Sat, 21 Aug 2021 at 13:17, Fabio M. De Francesco
<fmdefrancesco@xxxxxxxxx> wrote:
>
> On Saturday, August 21, 2021 12:56:15 PM CEST Phillip Potter wrote:
> > Remove forward declaration of Efuse_Read1ByteFromFakeContent function
> > from core/rtw_efuse.c, as the function is defined in full directly
> > after this and therefore this forward declaration is redundant.
> >
> > In addition, convert the storage class of the function to static, as the
> > function is only used with rtw_efuse.c, and tidy up the signature
> > alignment.
> >
> > Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
> > ---
> >
> > V1: Removed forward declaration.
> > V2: Takes account of feedback from Michael Straube and Fabio M. De
> > Francesco to make storage class of the function static.
>
> Thanks!
>
> Acked-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
>
> Cheers,
>
> Fabio
>
>

Thanks Fabio.

Regards,
Phil