RE: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()

[Sa, Nuno]

> From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Sent: Thursday, August 19, 2021 7:21 PM
> To: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx;
> prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx; jic23@xxxxxxxxxx
> Subject: Re: [PATCH -next] iio: adc: add missing
> clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()
> 
> On Thu, Aug 19, 2021 at 4:19 PM Yang Yingliang
> <yangyingliang@xxxxxxxxxx> wrote:
> >
> > Add clk_disable_unprepare() on error path in
> rzg2l_adc_pm_runtime_resume().
> 
> ...
> 
> >         ret = clk_prepare_enable(adc->adclk);
> > -       if (ret)
> > +       if (ret) {
> > +               clk_disable_unprepare(adc->pclk);
> >                 return ret;
> > +       }
> 
> Huh?!
> 

Had the same reaction when looked at this patch. Look at the
clock names :).

- Nuno Sá