Re: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()

From: Yang Yingliang
Date: Thu Aug 19 2021 - 21:52:40 EST


Hi,

On 2021/8/20 1:20, Andy Shevchenko wrote:
On Thu, Aug 19, 2021 at 4:19 PM Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
Add clk_disable_unprepare() on error path in rzg2l_adc_pm_runtime_resume().
...

ret = clk_prepare_enable(adc->adclk);
- if (ret)
+ if (ret) {
+ clk_disable_unprepare(adc->pclk);
return ret;
+ }
Huh?!
The pclk need be disabled, when enable adclk failed.
      ^                                                         ^^