Re: [PATCH] PCI: uniphier: Take lock in INTX irq_{mask,unmask,ack} callbacks

[Kunihiko Hayashi]

Hi Bjorn,
Thank you for checking.

On 2021/08/19 20:29, Bjorn Helgaas wrote:
> Possibly update subject to be more descriptive, along lines of:
>
>    Serialize INTx masking/unmasking

Okay, I'll apply it to the subject.

> On Thu, Aug 19, 2021 at 07:56:06PM +0900, Kunihiko Hayashi wrote:
> > The same condition register PCI_RCV_INTX is used in irq_mask(),
> > irq_unmask() and irq_ack() callbacks. Accesses to register can occur at the
> > same time without lock.
> > This introduces a lock into the callbacks to prevent the issue.
>
> Rewrap into a single paragraph or add blank line between paragraphs.
>
> s/This introduces/Add/ to make this an imperative description of what
> you want this patch to do.  No need for "This" since the context is
> obvious.

I see. I'll rewrite the message to convey it more directly.

Thank you,

---
Best Regards
Kunihiko Hayashi