[linux-platform-drivers-x86:review-hans 60/78] drivers/mfd/intel_pmc_bxt.c:181: undefined reference to `intel_scu_ipc_dev_simple_command'

From: kernel test robot
Date: Thu Aug 19 2021 - 14:11:45 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
head: b1341d3e93b26a85bb765f7eddd717d409bc1ef8
commit: 05c8d91f374b5dceeb322221eca48077005b1686 [60/78] platform/x86: intel_scu: Move to intel sub-directory
config: i386-randconfig-m021-20210818 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=05c8d91f374b5dceeb322221eca48077005b1686
git remote add linux-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
git fetch --no-tags linux-platform-drivers-x86 review-hans
git checkout 05c8d91f374b5dceeb322221eca48077005b1686
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

ld: drivers/mfd/intel_pmc_bxt.o: in function `simplecmd_store':
>> drivers/mfd/intel_pmc_bxt.c:181: undefined reference to `intel_scu_ipc_dev_simple_command'
ld: drivers/mfd/intel_pmc_bxt.o: in function `northpeak_store':
drivers/mfd/intel_pmc_bxt.c:221: undefined reference to `intel_scu_ipc_dev_simple_command'
ld: drivers/mfd/intel_pmc_bxt.o: in function `intel_pmc_probe':
>> drivers/mfd/intel_pmc_bxt.c:442: undefined reference to `__devm_intel_scu_ipc_register'

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for INTEL_SCU_IPC
Depends on X86 && X86_PLATFORM_DEVICES && X86_PLATFORM_DRIVERS_INTEL
Selected by
- MFD_INTEL_PMC_BXT && HAS_IOMEM && X86 && X86_PLATFORM_DEVICES && ACPI


vim +181 drivers/mfd/intel_pmc_bxt.c

25f1ca31e23059 Mika Westerberg 2020-04-16 152
25f1ca31e23059 Mika Westerberg 2020-04-16 153 /**
25f1ca31e23059 Mika Westerberg 2020-04-16 154 * simplecmd_store() - Send a simple IPC command
25f1ca31e23059 Mika Westerberg 2020-04-16 155 * @dev: Device under the attribute is
25f1ca31e23059 Mika Westerberg 2020-04-16 156 * @attr: Attribute in question
25f1ca31e23059 Mika Westerberg 2020-04-16 157 * @buf: Buffer holding data to be stored to the attribute
25f1ca31e23059 Mika Westerberg 2020-04-16 158 * @count: Number of bytes in @buf
25f1ca31e23059 Mika Westerberg 2020-04-16 159 *
25f1ca31e23059 Mika Westerberg 2020-04-16 160 * Expects a string with two integers separated with space. These two
25f1ca31e23059 Mika Westerberg 2020-04-16 161 * values hold command and subcommand that is send to PMC.
25f1ca31e23059 Mika Westerberg 2020-04-16 162 *
25f1ca31e23059 Mika Westerberg 2020-04-16 163 * Return: Number number of bytes written (@count) or negative errno in
25f1ca31e23059 Mika Westerberg 2020-04-16 164 * case of error.
25f1ca31e23059 Mika Westerberg 2020-04-16 165 */
25f1ca31e23059 Mika Westerberg 2020-04-16 166 static ssize_t simplecmd_store(struct device *dev, struct device_attribute *attr,
25f1ca31e23059 Mika Westerberg 2020-04-16 167 const char *buf, size_t count)
25f1ca31e23059 Mika Westerberg 2020-04-16 168 {
25f1ca31e23059 Mika Westerberg 2020-04-16 169 struct intel_pmc_dev *pmc = dev_get_drvdata(dev);
25f1ca31e23059 Mika Westerberg 2020-04-16 170 struct intel_scu_ipc_dev *scu = pmc->scu;
25f1ca31e23059 Mika Westerberg 2020-04-16 171 int subcmd;
25f1ca31e23059 Mika Westerberg 2020-04-16 172 int cmd;
25f1ca31e23059 Mika Westerberg 2020-04-16 173 int ret;
25f1ca31e23059 Mika Westerberg 2020-04-16 174
25f1ca31e23059 Mika Westerberg 2020-04-16 175 ret = sscanf(buf, "%d %d", &cmd, &subcmd);
25f1ca31e23059 Mika Westerberg 2020-04-16 176 if (ret != 2) {
25f1ca31e23059 Mika Westerberg 2020-04-16 177 dev_err(dev, "Invalid values, expected: cmd subcmd\n");
25f1ca31e23059 Mika Westerberg 2020-04-16 178 return -EINVAL;
25f1ca31e23059 Mika Westerberg 2020-04-16 179 }
25f1ca31e23059 Mika Westerberg 2020-04-16 180
25f1ca31e23059 Mika Westerberg 2020-04-16 @181 ret = intel_scu_ipc_dev_simple_command(scu, cmd, subcmd);
25f1ca31e23059 Mika Westerberg 2020-04-16 182 if (ret)
25f1ca31e23059 Mika Westerberg 2020-04-16 183 return ret;
25f1ca31e23059 Mika Westerberg 2020-04-16 184
25f1ca31e23059 Mika Westerberg 2020-04-16 185 return count;
25f1ca31e23059 Mika Westerberg 2020-04-16 186 }
25f1ca31e23059 Mika Westerberg 2020-04-16 187 static DEVICE_ATTR_WO(simplecmd);
25f1ca31e23059 Mika Westerberg 2020-04-16 188

:::::: The code at line 181 was first introduced by commit
:::::: 25f1ca31e230598eaf3c38d387a355a64bd772a7 platform/x86: intel_pmc_ipc: Convert to MFD

:::::: TO: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
:::::: CC: Lee Jones <lee.jones@xxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip