Re: [PATCH v2 1/2] scsi: qla1280: Stop using scsi_cmnd.tag

[Hannes Reinecke]

On 8/19/21 11:32 AM, John Garry wrote:
> Use scsi_cmd_to_rq(cmd)->tag instead of scsi_cmnd.tag as preference.
>
> Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> ---
>   drivers/scsi/qla1280.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
> index aec92471c5f2..b4f7d8d7a01c 100644
> --- a/drivers/scsi/qla1280.c
> +++ b/drivers/scsi/qla1280.c
> @@ -3980,7 +3980,7 @@ __qla1280_print_scsi_cmd(struct scsi_cmnd *cmd)
>   	   qla1280_dump_buffer(1, (char *)sg, (cmd->use_sg*sizeof(struct scatterlist)));
>   	   } */
>   	printk("  tag=%d, transfersize=0x%x \n",
> -	       cmd->tag, cmd->transfersize);
> +	       scsi_cmd_to_rq(cmd)->tag, cmd->transfersize);
>   	printk("  SP=0x%p\n", CMD_SP(cmd));
>   	printk(" underflow size = 0x%x, direction=0x%x\n",
>   	       cmd->underflow, cmd->sc_data_direction);
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@xxxxxxx                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer