Re: [PATCH] usb: gadget: mv_u3d: Change functon call in mv_u3d_probe()

From: Felipe Balbi
Date: Wed Aug 18 2021 - 09:13:51 EST



Hi,

(first of all, your subject could be a little more descriptive,
something like:

usb: gadget: mv_u3d: request_irq() after initializing UDC

as that would better detail what you're doing)

Nadezda Lutovinova <lutovinova@xxxxxxxxx> writes:

> If IRQ occurs between calling request_irq() and mv_u3d_eps_init(),
> then null pointer dereference occurs since u3d->eps[] wasn't
> initialized yet but used in mv_u3d_nuke().
>
> The patch puts registration of the interrupt handler after
> initializing of neccesery data.
>
> Found by Linux Driver Verification project (linuxtesting.org).

this looks like an important bug fix, it probably deserves a stable tag
here. Which commit introduce this problem? Otherr than that, commits
looks good.

--
balbi