Re: [PATCH v3] soc: rockchip: io-domain: set 3.3V before regulator disable

From: Mark Brown
Date: Wed Aug 18 2021 - 08:28:41 EST


On Wed, Aug 18, 2021 at 09:09:56AM +0800, Jianqun Xu wrote:

> + } else if (event & REGULATOR_EVENT_ENABLE) {
> + uV = regulator_get_voltage(supply->reg);

I'm still not clear that the locking is safe here - the notifier is
called with the regulator lock held but regulator_get_voltage() wants to
take that lock. Have you tried this with the various lock debugging
stuff turned on?

Attachment: signature.asc
Description: PGP signature